#37922
85%

Ran 03 Oct 2024 10:39AM UTC

Jobs 1

Files 361

Run time 1min

Badge

Embed ▾

Committed 03 Oct 2024 12:46AM UTC coverage: 87.736% (+1.0%) from 86.72%

Build # #37922

Build Type

push

local

Committed by

web-flow

Commit Message

[build] avoid libedit linkage and align libccalllazy* SONAMEs (#55968)

While building the 1.11.0-rc4 in Homebrew[^1] in preparation for 1.11.0
release (and to confirm Sequoia successfully builds) I noticed some odd
linkage for our Linux builds, which included of:

1. LLVM libraries were linking to `libedit.so`, e.g.
    ```
    Dynamic Section:
      NEEDED       libedit.so.0
      NEEDED       libz.so.1
      NEEDED       libzstd.so.1
      NEEDED       libstdc++.so.6
      NEEDED       libm.so.6
      NEEDED       libgcc_s.so.1
      NEEDED       libc.so.6
      NEEDED       ld-linux-x86-64.so.2
      SONAME       libLLVM-16jl.so
    ```
    CMakeCache.txt showed
    ```
    //Use libedit if available.
    LLVM_ENABLE_LIBEDIT:BOOL=ON
    ```
Which might be overriding `HAVE_LIBEDIT` at
https://github.com/JuliaLang/llvm-project/blob/julia-release/16.x/llvm/cmake/config-ix.cmake#L222-L225.
So just added `LLVM_ENABLE_LIBEDIT`

2. Wasn't sure if there was a reason for this but `libccalllazy*` had
mismatched SONAME:
    ```console
    ❯ objdump -p lib/julia/libccalllazy* | rg '\.so'
    lib/julia/libccalllazybar.so:	file format elf64-x86-64
      NEEDED       ccalllazyfoo.so
      SONAME       ccalllazybar.so
    lib/julia/libccalllazyfoo.so:	file format elf64-x86-64
      SONAME       ccalllazyfoo.so
    ```
    Modifying this, but can drop if intentional.

---

[^1]: https://github.com/Homebrew/homebrew-core/pull/192116

Run Details

78782 of 89794 relevant lines covered (87.74%)

16687498.83 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	90.91	-0.41%	stdlib/Random/src/generation.jl
1	90.69	-0.05%	base/compiler/tfuncs.jl
3	78.26	-13.04%	base/locks-mt.jl
6	76.35	-0.61%	stdlib/Printf/src/Printf.jl
15	91.35	0.48%	base/abstractdict.jl
107	86.8	-0.05%	base/reflection.jl
136	81.11	-0.2%	stdlib/REPL/src/REPL.jl

Jobs

ID	Job ID	Ran	Files	Coverage
1	#37922.1	03 Oct 2024 10:39AM UTC	361	87.74

JuliaLang / julia / #37922
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37922

JuliaLang / julia / #37922 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37922

JuliaLang / julia / #37922
85%

README BADGES
x