Ouranosinc / xscen / 11109698085

90%

push

github

Add oblique mercator to `create_bounds` and other improvements to the regridding function (#467)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Renames `create_bounds_rotated_pole` to `create_bounds_gridmapping`
and adds support for `oblique_mercator`.
* Changes to `regrid_dataset`:
  * `weights_location` is now optional.
* Reinforced the automatic naming of the weights file. When attributes
are unknown, a random string is now generated instead of a static one.
Moreover, it now relies on a `cat:id` and `cat:domain` for both the
incoming dataset and the grid.
* Now correctly skips the `lon_bounds` and `lat_bounds` variables if the
grid was generated using `xesmf.util.cf_grid_2d`
* `create_mask` has been completely refactored to use real arguments
instead of a dictionary.

### Does this PR introduce a breaking change?

* The old function name is deprecated and will be dropped in a later
version.
* `weights_location` in `regrid_dataset` is now optional, and thus had
to be moved to explicit arguments rather than positional.

### Other information:

105 of 107 new or added lines in 1 file covered. (98.13%)

3508 of 4344 relevant lines covered (80.76%)

4.75 hits per line