Ouranosinc / xscen / 10961119634

90%

push

github

Remove last deprecated calendar functions - adapt to xclim's main (#465)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [ ] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Remove references to `convert_calendar` (removed from xclim > 0.52.2)
* Remove references to `get_calendar` (not removed but using xarray is
better)
* Fix issues with the move of `VARIABLES` and `ValidationError` within
xclim.
* Make test runnable with new testdata stuff. Not tested, of course.

### Does this PR introduce a breaking change?
No.

### Other information:

16 of 17 new or added lines in 5 files covered. (94.12%)

3420 of 4299 relevant lines covered (79.55%)

4.7 hits per line