nats-io / nats-server / 11099532654
85%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 57
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.423% (+0.1%) from 85.276%
11099532654

push

github

web-flow 
Reuse pre-existing sys account reference (#5934)

Fixes the following panic:
```
[inf] panic: runtime error: invalid memory address or nil pointer dereference
[inf] [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xc0a90d]
[inf]
[inf] goroutine 1 [running]:
[inf] github.com/nats-io/nats-server/v2/server.(*jetStream).setupMetaGroup(0xc0002c2200)
[inf] server/jetstream_cluster.go:877 +0x12ed
[inf] github.com/nats-io/nats-server/v2/server.(*Server).enableJetStreamClustering(0xc00023e008)
[inf] server/jetstream_cluster.go:759 +0x1af
[inf] github.com/nats-io/nats-server/v2/server.(*Server).enableJetStream(0xc00023e008, {0x40000000, 0x280000000, {0xc00002a3f0, 0x15}, 0x1bf08eb000, 0x0, {0x0, 0x0}, 0x1, ...})
[inf] server/jetstream.go:508 +0x11fc
[inf] github.com/nats-io/nats-server/v2/server.(*Server).EnableJetStream(0xc00023e008, 0xc000033d18)
[inf] server/jetstream.go:230 +0x945
[inf] github.com/nats-io/nats-server/v2/server.(*Server).Start(0xc00023e008)
[inf] server/server.go:2347 +0x2005
[inf] github.com/nats-io/nats-server/v2/server.Run(0xc00023e008)
[inf] server/service.go:22 +0x32
[inf] main.main()
[inf] main.go:127 +0x62c
```


The panic would occur if we were starting up and were in
`setupMetaGroup`, but while we're there we get shutdown.
```
[inf] [1] 2024/09/24 23:18:56.478586 [INF] Starting JetStream cluster
[inf] [1] 2024/09/24 23:18:56.478739 [DBG] JetStream cluster checking for stable cluster name and peers
[inf] [1] 2024/09/24 23:18:56.480463 [INF] Creating JetStream metadata controller
[inf] [1] 2024/09/24 23:18:56.501280 [INF] JetStream cluster recovering state
[inf] [1] 2024/09/24 23:18:56.554002 [DBG] Trapped "terminated" signal
[inf] [1] 2024/09/24 23:18:56.565929 [INF] Initiating Shutdown...
[inf] [1] 2024/09/24 23:18:56.568012 [INF] Initiating JetStream Shutdown...
[inf] [1] 2024/09/24 23:18:56.585020 [DBG] JETSTREAM - JetStream connection closed: Client Closed
[inf] [1] 2024/09/24 23:18:... (continued)

67021 of 78458 relevant lines covered (85.42%)

1455730.28 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
93.15
 -0.09% src/github.com/nats-io/nats-server/server/route.go
2
88.29
 -0.14% src/github.com/nats-io/nats-server/server/memstore.go
2
86.42
 0.3% src/github.com/nats-io/nats-server/server/events.go
3
87.88
 0.52% src/github.com/nats-io/nats-server/server/consumer.go
3
97.07
 -0.25% src/github.com/nats-io/nats-server/server/sublist.go
4
82.19
 0.0% src/github.com/nats-io/nats-server/server/jetstream.go
5
90.2
 -0.22% src/github.com/nats-io/nats-server/server/leafnode.go
6
83.44
 0.0% src/github.com/nats-io/nats-server/server/raft.go
6
80.95
 -0.07% src/github.com/nats-io/nats-server/server/opts.go
388
80.66
 0.58% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
Jobs
ID Job ID Ran Files Coverage
1 11099532654.1 57
85.42
 GitHub Action Run
Source Files on build 11099532654