babelfish-for-postgresql / babelfish_extensions / 11070088791

74%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Support PgAudit with Babelfish and addition of PgAudit github action … (#2981)

Following Issues were observed while testing of JDBC tests with pgaudit extension enabled.

Problem 1: Some crashes and diff files with the error as undefined objectId or classId.
Main issue was to over-write the address for the case T_CreateTableAsStmt. In this case we are setting the address via bbfSelectIntoUtility_hook and passing it further from there only. But due to improper check we are also over-writing that address with a random initialised variable in ProcessUtilitySlow.

Problem 2: there were some files which were giving diff file upon running with pgaudit as: "ERROR (Message: cache lookup failed for relation 24553)".
We were not initializing the cache when we enter ENRgetSystableScan() function for table object type. Fix is to change the dialect to tsql and then initialize the cache and then again change the dialect to earlier dialect via introducing a hook.

Problem 3: Diff files with the error unexpected command tag "???"
This issue arises when we call the identity() function via select into query. Upon debugging found that we  were not setting the object type while making the identity node (AlterTableStmt). Fix was to set the object type to object_table while making the identity node.

Added a new github action workflow to test JDBC tests after enabling pgaudit extension.

Engine changes PR link: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/453

Tasks : BABEL-5269, BABEL-5233, BABEL-5281

Signed-off-by: Pranav Jain <pranavjc@amazon.com>

Run Details

3 of 18 new or added lines in 2 files covered. (16.67%)

1 existing line in 1 file now uncovered.

42819 of 58111 relevant lines covered (73.68%)

146503.72 hits per line