11060145043
74%
BABEL_5_X_DEV: 77%

Ran 26 Sep 2024 09:43PM UTC

Jobs 1

Files 114

Run time 1min

Badge

Embed ▾

Committed 26 Sep 2024 08:58PM UTC coverage: 73.704% (+0.006%) from 73.698%

Build # 11060145043

Build Type

push

github

Committed by

web-flow

Commit Message

Fix crash when trying to alter temp table column type. (#2973)

In cases where a temp table column is being altered so that only the size changes (e.g. char(20) -> char(5)), the code path needs to drop the pg_depend entry from the normal catalog table (to be later recreated using the new target type). However, for ENR temp tables all catalog tuples are stored in currentQueryEnv and not actually in the catalogs themselves. Thus, the code would not be able to find the tuple for deletion, leading to an assertion error. Fix the issue by using ENRDropTuple() instead of CatalogTupleDelete() so that the code drops the tuple in the correct place.

Backport of babelfish-for-postgresql/postgresql_modified_for_babelfish#442

Note that there are additional changes compared to the original commit from babelfish-for-postgresql/postgresql_modified_for_babelfish#442 to allow this change to work with pg15, as there are commits which are present in pg16 which have not been backported to pg15 which are required for this change to work properly.

Task: BABEL-5273
Signed-off-by: Jason Teng <jasonten@amazon.com>

Run Details

42819 of 58096 relevant lines covered (73.7%)

146941.99 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
6	90.0	0.08%	contrib/babelfishpg_tds/src/backend/tds/tds_srv.c
39	84.0	0.44%	contrib/babelfishpg_tds/src/backend/tds/tdsprotocol.c
133	88.46	0.04%	contrib/babelfishpg_tsql/src/procedures.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	11060145043.1	26 Sep 2024 09:43PM UTC	114	73.7	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 11060145043
74%
BABEL_5_X_DEV: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11060145043

babelfish-for-postgresql / babelfish_extensions / 11060145043 74% BABEL_5_X_DEV: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 11060145043

babelfish-for-postgresql / babelfish_extensions / 11060145043
74%
BABEL_5_X_DEV: 77%

README BADGES
x