rust-bitcoin / rust-bitcoin / 11038857378

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3392: fix: script number overflow check for push_int

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/33edaf935d71167bb1bb92bc671272217852005a">33edaf935<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3bbad771723ce80848fd0f79d5476822850b4ec8"> fix: check overflow for push_int with push_int_unchecked (Chris Hyunhum Cho)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/876146154b4e480d85196461ee36cf3e8734d2b4">876146154</a> refactor: use push_lock_time instead of push_int (Chris Hyunhum Cho)

Pull request description:

  Fix the issue https://github.com/rust-bitcoin/rust-bitcoin/issues/1530. In the discussion of https://github.com/rust-bitcoin/rust-bitcoin/issues/1530, the suggested solution is to implement `ScriptInt` type to embrace the various type of integer(`i32, u32, i64, u64, i128, u128, isize, usize...`) to support both script number and locktime number.

  However, as `push_locktime` and `push_sequence` implemented, there’s no need to support `u32` of lock time for `push_int` anymore. Therefore, I’ve just changed the type of parameter to `i32`, and only check if it’s `i32::MIN`(which overflows 4 bytes sign-magnitude integer).

  ~I also added push_uint method to use internally for `push_locktime` and `push_sequence`, which have a dependency on `push_int` method.~

  UPDATE: also add `push_int_unchecked` for those who want to push the integer out of range(and helper for `push_locktime` and `push_sequence`, which has the same functionality of former `push_int`.

ACKs for top commit:
  tcharding:
    ACK 33edaf935d71167bb1bb92bc671272217852005a

Tree-SHA512: 89b02bd3facd553d07cfe4653050045fa07

19 of 26 new or added lines in 4 files covered. (73.08%)

18999 of 22937 relevant lines covered (82.83%)

18211.41 hits per line