rust-bitcoin / rust-bitcoin / 11038097026

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3386: transaction: Remove `Default` implementations

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d0a30096b4d3a9added5f0646f327b8fe41a5236">d0a30096b transaction: Remove Default implementations (Tobin C. Harding)

Pull request description:

  Currently we provide `Default` implementations for a couple of types in the `transaction` module, the values returned are meaningless and it seems these impls were added to make writing test code easier. In hindsight this was the wrong thing to do.

  Break the API and remove the `Default` implementations for `OutPoint` and `TxIn`.

  Add an associated const `TxIn::EMPTY_COINBASE` that is, as the name suggests, an empty transaction input with the prevout set to all zeros as for the coinbase transaction.

ACKs for top commit:
  apoelstra:
    ACK d0a30096b4d3a9added5f0646f327b8fe41a5236 successfully ran local tests

Tree-SHA512: f76c2984d39926d30fcb30b6f2083a7fbd7

Coverage Stats

7 of 7 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

18999 of 22932 relevant lines covered (82.85%)

18272.41 hits per line