rust-bitcoin / rust-bitcoin / 10905141643

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3356: Fix GetKey for sets (plus some related changes)

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/b593c886e34e89b7c628e9b34de84a0e20e805af">b593c886e<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1fe9b79f66fa8772237b677803798e9cae15be56"> Support GetKey where the Xpriv is a direct child of the looked up KeySource (Nadav Ivgi)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/055aa9d4dcc500183be087189363ac3270df9be9">055aa9d4d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1fe9b79f66fa8772237b677803798e9cae15be56"> Refactor GetKey to take the KeyRequest by reference (Nadav Ivgi)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d15c57bd1f4a3928ae5bfa23118c6d28f21b6b9d">d15c57bd1</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1fe9b79f66fa8772237b677803798e9cae15be56"> Refactor GetKey for sets to internally use Xpriv::get_key() (Nadav Ivgi)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d25c62bf4572dc76f00b4bf89f48cff1a01db04a">d25c62bf4</a> Fix GetKey for sets to properly compare the fingerprint (Nadav Ivgi)

Pull request description:

  - The first commit is the simplest fix for a bug where the fingerprint wasn't compared correctly.

  - The second & third commits are optional refactoring to reuse `Xpriv::get_key` for `$set<Xpriv>::get_key`, so the Xpriv matching logic only has to be maintained in one place.

  - The forth commit adds support for signing with `Xpriv`s that are direct children of the `KeySource` -- possibly what the original (buggy) code author had in mind?

  Of course, feel free to take just the first commit if the others seem unnecessary. The last one is kind of meh, not sure if really useful.

  Note that multi-`Xpriv` signing does not actually work until #2850 is addressed too.

ACKs for top commit:
  apoelstra:
    ACK b593c886e34e89b7c628e9b34de84a0e20e805af successfully ran local tests
  tcharding:
    ACK b593c886e34e89b7c628e9b34de84a0e20e805af

Tree-SHA512: a6f84fe1207d47f23488fb69754a993762a

Coverage Stats

4 of 19 new or added lines in 1 file covered. (21.05%)

1 existing line in 1 file now uncovered.

18930 of 22874 relevant lines covered (82.76%)

16353.19 hits per line