rust-bitcoin / rust-bitcoin / 10902500505

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3360: Improve documentation test in merkle_tree

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9fc2c2a5b1156282a20420aacd001c5ffd1c0aba">9fc2c2a5b Improve documentation test in merkle_tree (Jiri Jakes)

Pull request description:

  Removes unnecessary usage of vector and adds a missing assert. Closes #3353.

  Note: Kixunil in the [referred comment](https://github.com/rust-bitcoin/rust-bitcoin/pull/3288#discussion_r1756514494) wondered about missing 'unused variable' warning. It seems that rustdoc [adds](https://doc.rust-lang.org/rustdoc/write-documentation/documentation-tests.html#pre-processing-examples) allows to the documentation tests. However, these warnings [can be enabled](https://doc.rust-lang.org/rustdoc/write-documentation/documentation-tests.html#showing-warnings-in-doctests) on module level. Do we want that? I tried to enable and there are already some occurrences of unused variables and imports. Caveat: it seems that we can't deny warnings on that, only print the warnings to stdout with `--show-output`.

ACKs for top commit:
  apoelstra:
    ACK 9fc2c2a5b1156282a20420aacd001c5ffd1c0aba successfully ran local tests
  tcharding:
    ACK 9fc2c2a5b1156282a20420aacd001c5ffd1c0aba

Tree-SHA512: 776177a9061975d3f7f0c6df85db7093d80

18930 of 22872 relevant lines covered (82.76%)

16313.17 hits per line