10824300123
83%

Ran 12 Sep 2024 05:39AM UTC

Jobs 1

Files 57

Run time 1min

Badge

Embed ▾

Committed 11 Sep 2024 07:41PM UTC coverage: 85.293% (-0.05%) from 85.344%

Build # 10824300123

Build Type

push

github

Committed by

web-flow

Commit Message

Fix data race when moving a stream (#5880)

There was a data race that triggered in
`TestJetStreamSuperClusterMoveCancel` due to the addition of JetStream
asset version metadata.

All JS API requests receive user-provided
`StreamConfig`/`ConsumerConfig`, which ensures that any mutations done
in `setStaticStreamMetadata` for example is safe.

However, `jsLeaderServerStreamMoveRequest` and
`jsLeaderServerStreamCancelMoveRequest` would use the `sa.Config` from
the stream assignment and call into `jsClusteredStreamUpdateRequest`.
This resulted in a reference to the same `Metadata` map being available
and modified.

To ensure any changes made to config defaults or metadata doesn't result
in a data race, a `StreamConfig.clone` method is added.


[data-race-TestJetStreamSuperClusterMoveCancel.txt](https://github.com/user-attachments/files/16968281/data-race-TestJetStreamSuperClusterMoveCancel.txt)


Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

---------

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Run Details

66625 of 78113 relevant lines covered (85.29%)

1439791.22 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	10824300123.1	12 Sep 2024 05:39AM UTC	0	85.29	GitHub Action Run

Source Files on build 10824300123

Detailed source file information is not available for this build.

nats-io / nats-server / 10824300123
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10824300123

nats-io / nats-server / 10824300123 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10824300123

nats-io / nats-server / 10824300123
83%

README BADGES
x