expertiza / expertiza / #17839
48%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 294
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 47.569% (+32.2%) from 15.399%
#17839

push

web-flow 
Reimplement waitlists (#2841)

* reimplemented reassign_topic

* reassiggning teams in signup sheet  when team is deleted

* calling SignUpTopic methods using instance

* calling instance methods on signuptopic object instead of creating new instance

* updated comments

* removed the old reassign method in code

* changes for reimplementing waitlists

* added drop_waitlisted_topics method in assignment.rb

* updated drop_waitlisted_teams method in assignment.rb

* added Rspec Testcases for few methods

* refactoring sign_up_sheet.rb file

* refactoring signup_sheet.rb

* refactoring signed_up_team.rb

* added clear comments to sign_up_topic file methods

* added testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* added testcases for signedupteam

* updated signed_up_team and removed unnecessary methods

* testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* refactoring signed_up_team

* refactored method names & converted slot_available? method to instance method

* fixed delete signup for topic testcase

* fixed model rspec test cases

* fixed controller tests

* fixed model testcases

* updated participants_helper_spec

---------

Co-authored-by: root <root@vclvm177-181.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-237.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm179-69.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm178-244.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-167.vcl.ncsu.edu>

29 of 74 new or added lines in 7 files covered. (39.19%)

442 existing lines in 23 files now uncovered.

6467 of 13595 relevant lines covered (47.57%)

7.91 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
90.14
 90.14% app/controllers/sign_up_sheet_controller.rb
1
27.42
 27.42% app/models/sign_up_sheet.rb
2
42.22
 14.72% app/models/signed_up_team.rb
3
76.92
 76.92% app/controllers/teams_controller.rb
4
42.63
 8.12% app/models/assignment.rb
34
34.26
 8.97% app/models/sign_up_topic.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
44.23
 6.73% app/models/assignment_participant.rb
1
34.26
 8.97% app/models/sign_up_topic.rb
3
49.75
 6.09% app/models/user.rb
4
35.44
 -5.06% app/models/question.rb
4
26.98
 1.59% app/models/due_date.rb
4
46.43
 -14.29% app/models/vm_question_response_row.rb
5
41.82
 -0.91% app/models/vm_question_response.rb
6
25.0
 -75.0% app/helpers/join_team_requests_helper.rb
8
17.65
 -47.06% app/helpers/review_bids_helper.rb
8
36.54
 -11.54% app/models/response_map.rb
9
47.06
 -52.94% app/helpers/deadline_helper.rb
10
8.22
 -13.7% app/helpers/submitted_content_helper.rb
12
0.0
 -100.0% app/models/vm_question_response_score_cell.rb
13
77.63
 9.21% app/helpers/summary_helper.rb
17
42.63
 8.12% app/models/assignment.rb
22
69.33
 -29.33% app/helpers/authorization_helper.rb
24
25.76
 -21.21% app/helpers/assignment_helper.rb
25
28.4
 -30.86% app/helpers/participants_helper.rb
28
12.31
 -43.08% app/helpers/sign_up_sheet_helper.rb
30
25.56
 -9.44% app/models/response.rb
31
32.0
 -52.0% app/helpers/answer_helper.rb
68
34.78
 -59.13% app/helpers/grades_helper.rb
109
18.09
 -54.77% app/helpers/review_mapping_helper.rb
Jobs
ID Job ID Ran Files Coverage
1 #17839.1 294
47.57
Source Files on build #17839