expertiza / expertiza / #17840
48%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 294
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 32.359% (+17.0%) from 15.399%
#17840

push

web-flow 
Reimplement waitlists (#2841)

* reimplemented reassign_topic

* reassiggning teams in signup sheet  when team is deleted

* calling SignUpTopic methods using instance

* calling instance methods on signuptopic object instead of creating new instance

* updated comments

* removed the old reassign method in code

* changes for reimplementing waitlists

* added drop_waitlisted_topics method in assignment.rb

* updated drop_waitlisted_teams method in assignment.rb

* added Rspec Testcases for few methods

* refactoring sign_up_sheet.rb file

* refactoring signup_sheet.rb

* refactoring signed_up_team.rb

* added clear comments to sign_up_topic file methods

* added testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* added testcases for signedupteam

* updated signed_up_team and removed unnecessary methods

* testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* refactoring signed_up_team

* refactored method names & converted slot_available? method to instance method

* fixed delete signup for topic testcase

* fixed model rspec test cases

* fixed controller tests

* fixed model testcases

* updated participants_helper_spec

---------

Co-authored-by: root <root@vclvm177-181.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-237.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm179-69.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm178-244.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-167.vcl.ncsu.edu>

32 of 78 new or added lines in 7 files covered. (41.03%)

530 existing lines in 20 files now uncovered.

4924 of 15217 relevant lines covered (32.36%)

5.04 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
92.18
 59.98% app/models/team.rb
4
85.25
 50.74% app/models/assignment.rb
8
38.71
 38.71% app/models/sign_up_sheet.rb
9
0.0
 0.0% app/controllers/sign_up_sheet_controller.rb
9
0.0
 0.0% app/controllers/teams_controller.rb
15
73.15
 47.86% app/models/sign_up_topic.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
38.71
 38.71% app/models/sign_up_sheet.rb
1
0.0
 0.0% app/controllers/sign_up_sheet_controller.rb
1
89.34
 45.69% app/models/user.rb
2
66.67
 -16.67% app/models/assignment_questionnaire.rb
2
0.0
 0.0% app/controllers/teams_controller.rb
4
78.57
 17.86% app/models/vm_question_response_row.rb
6
25.0
 -75.0% app/helpers/join_team_requests_helper.rb
8
17.65
 -47.06% app/helpers/review_bids_helper.rb
9
38.1
 -14.29% app/models/teams_user.rb
9
47.06
 -52.94% app/helpers/deadline_helper.rb
10
8.22
 -13.7% app/helpers/submitted_content_helper.rb
19
35.8
 -23.46% app/helpers/participants_helper.rb
24
10.61
 -36.36% app/helpers/assignment_helper.rb
28
12.31
 -43.08% app/helpers/sign_up_sheet_helper.rb
34
16.0
 -68.0% app/helpers/answer_helper.rb
37
19.74
 -48.68% app/helpers/summary_helper.rb
48
34.67
 -64.0% app/helpers/authorization_helper.rb
86
0.0
 -15.08% app/controllers/grades_controller.rb
92
13.91
 -80.0% app/helpers/grades_helper.rb
109
18.09
 -54.77% app/helpers/review_mapping_helper.rb
Jobs
ID Job ID Ran Files Coverage
1 #17840.1 294
32.36
Source Files on build #17840