expertiza / expertiza / #17838
48%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 294
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 15.47% (+0.07%) from 15.399%
#17838

push

web-flow 
Reimplement waitlists (#2841)

* reimplemented reassign_topic

* reassiggning teams in signup sheet  when team is deleted

* calling SignUpTopic methods using instance

* calling instance methods on signuptopic object instead of creating new instance

* updated comments

* removed the old reassign method in code

* changes for reimplementing waitlists

* added drop_waitlisted_topics method in assignment.rb

* updated drop_waitlisted_teams method in assignment.rb

* added Rspec Testcases for few methods

* refactoring sign_up_sheet.rb file

* refactoring signup_sheet.rb

* refactoring signed_up_team.rb

* added clear comments to sign_up_topic file methods

* added testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* added testcases for signedupteam

* updated signed_up_team and removed unnecessary methods

* testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* refactoring signed_up_team

* refactored method names & converted slot_available? method to instance method

* fixed delete signup for topic testcase

* fixed model rspec test cases

* fixed controller tests

* fixed model testcases

* updated participants_helper_spec

---------

Co-authored-by: root <root@vclvm177-181.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-237.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm179-69.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm178-244.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-167.vcl.ncsu.edu>

10 of 79 new or added lines in 7 files covered. (12.66%)

7 existing lines in 4 files now uncovered.

2421 of 15650 relevant lines covered (15.47%)

1.24 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
32.4
 0.2% app/models/team.rb
3
28.89
 1.39% app/models/signed_up_team.rb
4
34.32
 -0.19% app/models/assignment.rb
9
0.0
 0.0% app/controllers/sign_up_sheet_controller.rb
9
0.0
 0.0% app/controllers/teams_controller.rb
9
0.0
 0.0% app/models/sign_up_sheet.rb
34
24.07
 -1.21% app/models/sign_up_topic.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% app/controllers/sign_up_sheet_controller.rb
1
24.07
 -1.21% app/models/sign_up_topic.rb
2
0.0
 0.0% app/controllers/teams_controller.rb
3
0.0
 0.0% app/models/sign_up_sheet.rb
Jobs
ID Job ID Ran Files Coverage
1 #17838.1 294
15.47
Source Files on build #17838