expertiza / expertiza / #17837
48%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 294
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 12.413% (-3.0%) from 15.399%
#17837

push

web-flow 
Reimplement waitlists (#2841)

* reimplemented reassign_topic

* reassiggning teams in signup sheet  when team is deleted

* calling SignUpTopic methods using instance

* calling instance methods on signuptopic object instead of creating new instance

* updated comments

* removed the old reassign method in code

* changes for reimplementing waitlists

* added drop_waitlisted_topics method in assignment.rb

* updated drop_waitlisted_teams method in assignment.rb

* added Rspec Testcases for few methods

* refactoring sign_up_sheet.rb file

* refactoring signup_sheet.rb

* refactoring signed_up_team.rb

* added clear comments to sign_up_topic file methods

* added testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* added testcases for signedupteam

* updated signed_up_team and removed unnecessary methods

* testcases

Conflicts:
	spec/models/sign_up_topic_spec.rb

* refactoring signed_up_team

* refactored method names & converted slot_available? method to instance method

* fixed delete signup for topic testcase

* fixed model rspec test cases

* fixed controller tests

* fixed model testcases

* updated participants_helper_spec

---------

Co-authored-by: root <root@vclvm177-181.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-237.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm179-69.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm178-244.vcl.ncsu.edu>
Co-authored-by: root <root@vclvm177-167.vcl.ncsu.edu>

10 of 79 new or added lines in 7 files covered. (12.66%)

979 existing lines in 39 files now uncovered.

1951 of 15718 relevant lines covered (12.41%)

0.25 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
20.67
 -11.53% app/models/team.rb
3
28.89
 1.39% app/models/signed_up_team.rb
4
29.22
 -5.29% app/models/assignment.rb
9
0.0
 0.0% app/controllers/sign_up_sheet_controller.rb
9
0.0
 0.0% app/controllers/teams_controller.rb
9
0.0
 0.0% app/models/sign_up_sheet.rb
34
24.07
 -1.21% app/models/sign_up_topic.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% app/controllers/sign_up_sheet_controller.rb
1
36.54
 -0.96% app/models/assignment_participant.rb
1
24.07
 -1.21% app/models/sign_up_topic.rb
2
66.67
 -16.67% app/models/assignment_questionnaire.rb
2
0.0
 0.0% app/controllers/teams_controller.rb
2
24.32
 -5.41% app/helpers/file_helper.rb
3
0.0
 0.0% app/models/sign_up_sheet.rb
4
35.44
 -5.06% app/models/question.rb
4
19.05
 -6.35% app/models/due_date.rb
5
37.5
 -62.5% app/models/logger_message.rb
5
41.12
 -2.54% app/models/user.rb
6
25.0
 -75.0% app/helpers/join_team_requests_helper.rb
8
17.65
 -47.06% app/helpers/review_bids_helper.rb
8
35.16
 -8.79% app/models/role.rb
8
32.69
 -15.38% app/models/response_map.rb
9
30.95
 -21.43% app/models/teams_user.rb
9
47.06
 -52.94% app/helpers/deadline_helper.rb
10
8.22
 -13.7% app/helpers/submitted_content_helper.rb
10
0.0
 -28.57% app/models/bid.rb
12
0.0
 -100.0% app/models/vm_question_response_score_cell.rb
13
0.0
 -54.55% app/models/team_user_node.rb
15
31.91
 -10.64% app/models/assignment_team.rb
21
20.67
 -11.53% app/models/team.rb
24
10.61
 -36.36% app/helpers/assignment_helper.rb
26
0.0
 -60.71% app/models/vm_question_response_row.rb
28
12.31
 -43.08% app/helpers/sign_up_sheet_helper.rb
28
29.22
 -5.29% app/models/assignment.rb
29
0.0
 -56.67% app/models/expertiza_logger.rb
30
18.33
 -16.67% app/models/response.rb
34
16.0
 -68.0% app/helpers/answer_helper.rb
37
19.74
 -48.68% app/helpers/summary_helper.rb
38
12.35
 -46.91% app/helpers/participants_helper.rb
44
0.0
 -15.28% app/mailers/mailer.rb
48
34.67
 -64.0% app/helpers/authorization_helper.rb
83
0.0
 -40.82% app/controllers/application_controller.rb
84
0.0
 -42.73% app/models/vm_question_response.rb
86
0.0
 -15.08% app/controllers/grades_controller.rb
92
13.91
 -80.0% app/helpers/grades_helper.rb
109
18.09
 -54.77% app/helpers/review_mapping_helper.rb
Jobs
ID Job ID Ran Files Coverage
1 #17837.1 294
12.41
Source Files on build #17837