curationexperts / laevigata / 59d2f4b5-c4de-47ef-a785-9abd71edbf14

94%

main: 97%

Build Type

Pull #2384

circleci

Committed by mark-dce

Commit Message

[REFACTOR] Simplify embargo management code

**ISSUE**
Very similar code existed in at least four locations to translate
embargo settings:
* [Actor Stack](https://github.com/curationexperts/laevigata/blob/v12.38.4/app/actors/hyrax/actors/etd_actor.rb#L24-L30)
* [ETDs Controller](https://github.com/curationexperts/laevigata/blob/v12.38.4/app/controllers/hyrax/etds_controller.rb#L282-L303)
* [Library code (EmbargoTypeFromAttributes)](https://github.com/curationexperts/laevigata/blob/v12.38.4/app/lib/embargo_type_from_attributes.rb#L8-L18)
* [Visibility Translator service](https://github.com/curationexperts/laevigata/blob/v12.38.4/app/services/visibility_translator.rb#L46-L56)

In addition, two different schemes were used to identify the
embargo type: one type followed the constants in the visibility
translation service, the other used a string representation of a
boolean array like much of the javascript.

**RATIONALE**
This change refactors all code that relates to embargo levels to use
the visibility constants. This allows us to:
1. Remove duplicative library code entirely
2. Remove controller code that duplicates actor stack functionality
3. Use parallel terminology in both Javascript and Rails code
4. Mirror the `visibility_ssi` values indexed into Solr

**NOTE**
Solr indexes ETDs with a `visibility_ssi` value. Current stats are
```
"facet_fields":{
      "visibility_ssi":[
        "open",11086,
        "files_restricted",854,
        "all_restricted",624,
        "toc_restricted",85,
        "restricted",2,
        null,0]}
```

Pull Request Pull Request #2384: [REFACTOR] Simplify embargo management code

Run Details

15 of 22 new or added lines in 4 files covered. (68.18%)

231 existing lines in 30 files now uncovered.

3029 of 3230 relevant lines covered (93.78%)

52.77 hits per line