Ouranosinc / xclim / 10707481039

92%

push

github

FIX: Standardize method applied on individual variables in OTC/dOTC (#1896)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [ ] CHANGELOG.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* The mean and std in the 'standardize' normalization method of OTC/dOTC
now is correctly applied on each variable individually
* While we're at it, I suggest changing the argument `transform` to
`normalization` which I feel is more specific and informative. Also, in
`optimal_transport`, we should follow the snake convention, `numIterMax`
-> `num_iter_max` (I guess this was done to imitate the signature of
`ot.emd`, but I think we need to stick to a standard in `xclim`
functions)

### Does this PR introduce a breaking change?
* `transform` -> `normalization` in input arguments.

### Other information:

7 of 10 new or added lines in 3 files covered. (70.0%)

9094 of 10173 relevant lines covered (89.39%)

7.52 hits per line