#37891
87%

Ran 02 Sep 2024 11:21AM UTC

Jobs 1

Files 360

Run time 4min

Badge

Embed ▾

Committed 02 Sep 2024 03:17AM UTC coverage: 86.931% (-0.8%) from 87.765%

Build # #37891

Build Type

push

local

Committed by

web-flow

Commit Message

Fix errant lmul! for tridiagonal and triangular (#55546)

This method is incorrect. Firstly, the current implementation doesn't
act in-place. Secondly, the result can't be stored in-place into a
triangular matrix in general. This PR changes the implementation to
convert the tridiagonal matrix to a `Diagonal` or a `Bidiagonal` one
before attempting the `lmul!`.
Currently,
```julia
julia> T = Tridiagonal([1,2], [1,2,3], [1,2]); U = UpperTriangular(fill(2, 3, 3));

julia> lmul!(T, U)
3×3 Matrix{Int64}:
 2  4   4
 2  6  10
 0  4  10

julia> U # not updated
3×3 UpperTriangular{Int64, Matrix{Int64}}:
 2  2  2
 ⋅  2  2
 ⋅  ⋅  2

julia> parent(U) # except for the underlying storage
3×3 Matrix{Int64}:
 2  2  2
 0  2  2
 0  0  2
```
After this,
```julia
julia> lmul!(T, U)
ERROR: ArgumentError: matrix cannot be represented as Bidiagonal
```

I'm unsure if we want this method at all, since there isn't a
corresponding `rmul!`, but I've left it there to avoid breakages, if
any.

Run Details

77318 of 88942 relevant lines covered (86.93%)

15861165.29 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	89.25	-1.18%	base/error.jl
1	73.24	-1.41%	base/libuv.jl
1	66.88	-0.64%	base/libc.jl
1	66.67	-6.67%	stdlib/OpenBLAS_jll/src/OpenBLAS_jll.jl
1	90.82	-0.18%	stdlib/LinearAlgebra/src/matmul.jl
1	86.41	-0.26%	base/boot.jl
2	69.59	-1.34%	base/Base.jl
2	86.51	-0.93%	base/indices.jl
2	76.15	-1.83%	base/experimental.jl
2	93.72	-0.17%	base/bitarray.jl
2	53.74	-1.36%	base/timing.jl
2	83.85	-1.24%	stdlib/LinearAlgebra/src/adjtrans.jl
2	72.9	-2.33%	base/c.jl
3	86.96	-0.33%	base/reflection.jl
3	92.53	-0.11%	stdlib/LinearAlgebra/src/triangular.jl
4	89.83	-0.47%	base/multidimensional.jl
4	74.78	-1.17%	base/client.jl
6	72.41	-4.14%	base/terminfo.jl
8	83.51	-4.26%	base/essentials.jl
10	75.17	-6.71%	base/ryu/fixed.jl
11	92.06	-5.82%	base/ryu/exp.jl
11	48.15	-40.74%	base/ryu/Ryu.jl
13	94.26	-1.81%	stdlib/LinearAlgebra/src/diagonal.jl
14	64.1	-35.9%	base/some.jl
15	87.81	-0.77%	base/show.jl
20	74.47	-14.02%	base/stacktraces.jl
23	76.28	-1.06%	base/loading.jl
28	73.89	-8.31%	base/ryu/shortest.jl
29	59.72	-5.87%	base/task.jl
57	33.06	-47.11%	base/summarysize.jl
77	22.12	-68.86%	stdlib/InteractiveUtils/src/macros.jl
79	40.25	-49.69%	stdlib/InteractiveUtils/src/InteractiveUtils.jl
201	33.86	-62.97%	stdlib/InteractiveUtils/src/codeview.jl
208	59.73	-31.18%	base/errorshow.jl

Jobs

ID	Job ID	Ran	Files	Coverage
1	#37891.1	02 Sep 2024 11:21AM UTC	360	86.93

JuliaLang / julia / #37891
87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37891

JuliaLang / julia / #37891 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37891

JuliaLang / julia / #37891
87%

README BADGES
x