#37891
77%

Ran 02 Sep 2024 11:21AM UTC

Jobs 1

Files 360

Run time 4min

Badge

Embed ▾

Committed 02 Sep 2024 03:17AM UTC coverage: 86.931% (-0.8%) from 87.765%

Build # #37891

Build Type

push

local

Committed by

web-flow

Commit Message

Fix errant lmul! for tridiagonal and triangular (#55546)

This method is incorrect. Firstly, the current implementation doesn't
act in-place. Secondly, the result can't be stored in-place into a
triangular matrix in general. This PR changes the implementation to
convert the tridiagonal matrix to a `Diagonal` or a `Bidiagonal` one
before attempting the `lmul!`.
Currently,
```julia
julia> T = Tridiagonal([1,2], [1,2,3], [1,2]); U = UpperTriangular(fill(2, 3, 3));

julia> lmul!(T, U)
3×3 Matrix{Int64}:
 2  4   4
 2  6  10
 0  4  10

julia> U # not updated
3×3 UpperTriangular{Int64, Matrix{Int64}}:
 2  2  2
 ⋅  2  2
 ⋅  ⋅  2

julia> parent(U) # except for the underlying storage
3×3 Matrix{Int64}:
 2  2  2
 0  2  2
 0  0  2
```
After this,
```julia
julia> lmul!(T, U)
ERROR: ArgumentError: matrix cannot be represented as Bidiagonal
```

I'm unsure if we want this method at all, since there isn't a
corresponding `rmul!`, but I've left it there to avoid breakages, if
any.

Run Details

77318 of 88942 relevant lines covered (86.93%)

15861165.29 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#37891.1	02 Sep 2024 11:21AM UTC	0	86.93

Source Files on build #37891

Detailed source file information is not available for this build.

JuliaLang / julia / #37891
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #37891

JuliaLang / julia / #37891 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #37891

JuliaLang / julia / #37891
77%

README BADGES
x