Unleash / unleash / 10594343953

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: change .inc calls to .increment (#8000)

We are observing incorrect data in Prometheus, which is consistently
non-reproducible. After a restart, the issue does not occur, but if the
pods run for an extended period, they seem to enter a strange state
where the counters become entangled and start sharing arbitrary values
that are added to the counters.

For example, the `feature_lifecycle_stage_entered` counter gets an
arbitrary value, such as 12, added when `inc()` is called. The
`exceedsLimitErrorCounter` shows the same behavior, and the code
implementation is identical.

We also tested some existing `increase()` counters, and they do not
suffer from this issue.

All calls to `counter.labels(labels).inc(`) will be replaced by
`counter.increment()` to try to mitigate the issue.

Coverage Stats

2702 of 3537 branches covered (76.39%)

1 of 6 new or added lines in 1 file covered. (16.67%)

3 existing lines in 2 files now uncovered.

13680 of 15623 relevant lines covered (87.56%)

711.15 hits per line