tarantool / tarantool / 10580740899
87%
master: 87%

LAST BUILD BRANCH: persistent_gc_out_of_replica
DEFAULT BRANCH: master
Ran
Jobs 1
Files 514
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.224% (+0.02%) from 87.205%
10580740899

push

github

Gerold103 
test: fix #5430 test

The test blocked on the `wait_log` for registering replica2 on the master
node. The `wait_log` does not throw an error on timeout, and its return
value is ignored in the test, so the test simply continued after the
timeout and succeeded.

The reason the test blocked was that after 70a6883 we are unable to
register an anonymous replica while its relay has not stopped:
https://github.com/tarantool/tarantool/blob/<a class=hub.com/tarantool/tarantool/commit/<a class="double-link" href="https://git"><a class=hub.com/tarantool/tarantool/commit/9e616ab6f2f94ba2bcad3044187c474a1c05a8c5">9e616ab6f/src/box/box.cc#L4422-L4427

At the same time, the anonymous replica's relay cannot finish, because it
is blocked by `cbus_unpair` in `wal_clear_watcher`:
https://github.com/tarantool/tarantool/blob/9e616ab6f2f94ba2bcad3044187c474a1c05a8c5/src/box/relay.cc#L1068-L1074
https://github.com/tarantool/tarantool/blob/9e616ab6f2f94ba2bcad3044187c474a1c05a8c5/src/lib/core/cbus.h#L440-L442

To fix this let's move `ERRINJ_REPLICA_JOIN_DELAY` before
`box_register_replica`. This error injection is not used right now, so we
can reuse it here instead of `ERRINJ_WAL_DELAY`. This way the WAL won't get
blocked, and we will be able to get 2 concurrent replica registrations.

Let's also echo the `wait_log` result to make sure the fails in the future.

Closes #9617

NO_CHANGELOG=<test fix>
NO_DOC=<test fix>

68358 of 121593 branches covered (56.22%)

1 of 1 new or added line in 1 file covered. (100.0%)

242 existing lines in 17 files now uncovered.

101017 of 115813 relevant lines covered (87.22%)

2464496.47 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
97.94
 -1.03% src/lib/vclock/vclock.c
1
98.26
 0.03% src/box/txn.h
1
90.93
 -0.1% src/box/vy_scheduler.c
1
94.99
 0.0% src/box/replication.cc
1
94.18
 -0.18% src/box/xrow_update_field.c
1
84.25
 -0.37% src/lib/core/coio.c
2
93.4
 -0.33% src/box/txn_limbo.c
2
95.4
 -2.3% src/histogram.c
2
92.94
 0.01% src/lib/core/fiber.c
2
84.45
 0.01% src/box/xlog.c
3
92.81
 -2.16% src/box/vy_point_lookup.c
4
95.62
 -0.22% src/box/iproto.cc
4
93.31
 -1.27% src/lib/swim/swim_io.c
5
94.1
 0.01% src/box/memtx_space.c
25
93.64
 0.13% src/box/txn.c
46
95.72
 0.02% src/box/memtx_tx.c
141
92.17
 0.0% src/box/vinyl.c
Jobs
ID Job ID Ran Files Coverage
1 10580740899.1 514
87.22
 GitHub Action Run
Source Files on build 10580740899