• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tarantool / tarantool / 10560954816
87%
master: 88%

Build:
Build:
LAST BUILD BRANCH: app-threads-module
DEFAULT BRANCH: master
Ran 26 Aug 2024 01:54PM UTC
Jobs 1
Files 514
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

26 Aug 2024 11:18AM UTC coverage: 87.205% (+0.03%) from 87.176%
10560954816

push

github

locker
vinyl: do not discard run on dump/compaction abort if index was dropped

If an index is dropped while a dump or compaction task is in progress
we must not write any information about it to the vylog when the task
completes otherwise there's a risk of getting a vylog recovery failure
in case the garbage collector manages to purge the index from the vylog.

We disabled logging on successful completion of a dump task quite a
while ago, in commit 29e2931c66c5 ("vinyl: fix race between compaction
and gc of dropped LSM"), and for compaction only recently, in commit
ae6a02ebab0b ("vinyl: do not log dump if index was dropped"), but the
issue remains for a dump/compaction failure, when we log a discard
record for a run file we failed to write. These results in errors like:

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Run 6 deleted twice
```

or

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Run 5768 deleted but not registered
```

Let's fix these issues in exactly the same way as we fixed them for
successful dump/compaction completion - by skipping writing to vylog
in case the index is marked as dropped.

Closes #10452

NO_DOC=bug fix

68310 of 121545 branches covered (56.2%)

6 of 6 new or added lines in 1 file covered. (100.0%)

26 existing lines in 15 files now uncovered.

100975 of 115791 relevant lines covered (87.2%)

2462360.91 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10560954816.1 26 Aug 2024 01:54PM UTC 0
87.2
GitHub Action Run
Source Files on build 10560954816
Detailed source file information is not available for this build.
  • Back to Repo
  • de59504c on github
  • Prev Build on release/3.2 (#10555395899)
  • Next Build on release/3.2 (#10580740899)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc