rust-bitcoin / rust-bitcoin / 10540415274

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3216: ecdsa: Improve error types

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9fb5edb39e55e576a54d9804ddae2fa8009f582a">9fb5edb39 ecdsa: Improve error types (Tobin C. Harding)

Pull request description:

  There are a couple of issues around the ECDSA signature decoding / parsing code. We have duplicate code in `from_str` and `from_slice` and both use the same error type even though it is impossible to get a hex error in `from_slice`.

  Create two errors:

  - A `DecodeError` returned by `from_slice`
  - A `FromStrError` that has a decode variant and a hex variant

  Call through to `from_slice` after parsing hex into a byte vector.

  Removes an instance of `unreachable!`.

  Fix: #1193

ACKs for top commit:
  Kixunil:
    ACK 9fb5edb39e55e576a54d9804ddae2fa8009f582a
  apoelstra:
    ACK 9fb5edb39e55e576a54d9804ddae2fa8009f582a successfully ran local tests

Tree-SHA512: 3b3ae31884dbbfefb94946d30558dbd2620

Coverage Stats

5 of 25 new or added lines in 2 files covered. (20.0%)

1 existing line in 1 file now uncovered.

19644 of 23734 relevant lines covered (82.77%)

15655.63 hits per line