rust-bitcoin / rust-bitcoin / 10539158634

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2972: Use index size rather than pointer size to enforce convertibility of `u32` to `usize`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c427d8b21388951718f21f00d9f02da22d9a62f7">c427d8b21<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/837fc9c9c2542942927be4bb46902b21d2bf8bcb"> bitcoin: Compile time assert on index size (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/49a6acc1a0129b9403f44d20880e44624def21ec">49a6acc1a</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/837fc9c9c2542942927be4bb46902b21d2bf8bcb"> internals: Remove double parenthesis in const_assert (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2300b285ef6a12a8ebfbbce0439be95465714ba0">2300b285e</a> units: Remove compile time pointer width check (Tobin C. Harding)

Pull request description:

  3 patches in preparation for other size related work, this PR does not touch the `ToU64` issue which will be handled separately.

  - Patch 1: Don't check pointer width in `units` because its not consensus code
  - Patch 2: Modify internal macro `const_assert`
  - Patch 3: Use index size to enforce not building on a 16 bit machine

ACKs for top commit:
  Kixunil:
    ACK c427d8b21388951718f21f00d9f02da22d9a62f7 though I think the last commit was kinda a waste of time and it should have been adding the trait instead or leave it for later.
  apoelstra:
    ACK c427d8b21388951718f21f00d9f02da22d9a62f7 successfully ran local tests; unsure if we want to merg this or wait for #3215

Tree-SHA512: 823df5b6a5f9656856732ff221b4129edf8

19645 of 23723 relevant lines covered (82.81%)

15642.73 hits per line