JuliaLang / julia / #37879

77%

Build Type

push

local

Committed by web-flow

Commit Message

Fix indexing in _mapreducedim for OffsetArrays (#55506)

The destination array was being indexed incorrectly if it had offset
indices. This led to the following on nightly:
```julia
julia> using OffsetArrays

julia> r = 5:100;

julia> a = OffsetVector(r, 2);

julia> sum(a, dims=1)
1-element OffsetArray(::Vector{Int64}, 3:3) with eltype Int64 with indices 3:3:
 0

julia> sum(a)
5040
```
The indexing was marked `@inbounds`, so this was not throwing an error.
This PR also follows #55329 and only marks the indexing operations as
`@inbounds`, omitting the function calls.

---------

Co-authored-by: Matt Bauman <mbauman@juliahub.com>

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

104 existing lines in 6 files now uncovered.

78198 of 89021 relevant lines covered (87.84%)

16442756.62 hits per line