10519998900
83%

Ran 23 Aug 2024 05:35AM UTC

Jobs 1

Files 56

Run time 2min

Badge

Embed ▾

Committed 23 Aug 2024 12:03AM UTC coverage: 85.183% (-0.04%) from 85.225%

Build # 10519998900

Build Type

push

github

Committed by

web-flow

Commit Message

[IMPROVED] Do not load blocks unnecessarily when checking if we can skip ahead in LoadNextMsg(). (#5819)

When we would miss a LoadNextMsg() from the block associated with the
starting sequence, we would check if we could skip ahead. The logic for
this could load old blocks, behind where we were, if the psim fblk was
outdated, causing memory bloat for cache expiration time intervals.

We reworked this to load no blocks in the skip check since this is hot
path for LoadNextMsg() and the linear scan, if applicable, properly will
expire anything loaded that did not contain a match.

I tested that benchmarks were not affected.

`go test -v -run=XXX --bench=Benchmark_FileStoreLoadNext`

Signed-off-by: Derek Collison <derek@nats.io>

Run Details

66247 of 77770 relevant lines covered (85.18%)

1143306.02 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	10519998900.1	23 Aug 2024 05:35AM UTC	0	85.18	GitHub Action Run

Source Files on build 10519998900

Detailed source file information is not available for this build.

nats-io / nats-server / 10519998900
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10519998900

nats-io / nats-server / 10519998900 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10519998900

nats-io / nats-server / 10519998900
83%

README BADGES
x