10519998900
86%

Ran 23 Aug 2024 05:35AM CUT

Jobs 1

Files 56

Run time 2min

Badge

Embed ▾

Committed 23 Aug 2024 12:03AM CUT coverage: 85.183% (-0.04%) from 85.225%

Build # 10519998900

Build Type

push

github

Committed by

web-flow

Commit Message

[IMPROVED] Do not load blocks unnecessarily when checking if we can skip ahead in LoadNextMsg(). (#5819)

When we would miss a LoadNextMsg() from the block associated with the
starting sequence, we would check if we could skip ahead. The logic for
this could load old blocks, behind where we were, if the psim fblk was
outdated, causing memory bloat for cache expiration time intervals.

We reworked this to load no blocks in the skip check since this is hot
path for LoadNextMsg() and the linear scan, if applicable, properly will
expire anything loaded that did not contain a match.

I tested that benchmarks were not affected.

`go test -v -run=XXX --bench=Benchmark_FileStoreLoadNext`

Signed-off-by: Derek Collison <derek@nats.io>

Run Details

66247 of 77770 relevant lines covered (85.18%)

1143306.02 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	93.58	0.0%	src/github.com/nats-io/nats-server/server/route.go
2	94.33	0.25%	src/github.com/nats-io/nats-server/server/gateway.go
2	82.14	0.0%	src/github.com/nats-io/nats-server/server/jetstream.go
2	70.47	0.06%	src/github.com/nats-io/nats-server/server/jetstream_api.go
2	81.32	0.0%	src/github.com/nats-io/nats-server/server/opts.go
5	90.12	-0.22%	src/github.com/nats-io/nats-server/server/leafnode.go
6	86.31	-0.09%	src/github.com/nats-io/nats-server/server/accounts.go
7	50.59	-0.59%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
7	94.71	0.09%	src/github.com/nats-io/nats-server/server/client.go
8	83.33	0.1%	src/github.com/nats-io/nats-server/server/raft.go
15	84.43	-0.25%	src/github.com/nats-io/nats-server/server/stream.go
24	79.7	0.03%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
29	86.89	-0.72%	src/github.com/nats-io/nats-server/server/consumer.go
810	83.78	0.07%	src/github.com/nats-io/nats-server/server/filestore.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	10519998900.1	23 Aug 2024 05:35AM CUT	56	85.18	GitHub Action Run

Source Files on build 10519998900

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
50.22	src/github.com/nats-io/nats-server/server/proto.go	268	227	114	113	10.0
50.59	...o/nats-server/server/jetstream_errors_generated.go	2461	1188	601 - 7	587 + 7	3058.0 + 212
58.76	...github.com/nats-io/nats-server/internal/ldap/dn.go	305	194	114	80	117.0
62.5	src/github.com/nats-io/nats-server/server/const.go	53	8	5	3	2.0
68.45	...github.com/nats-io/nats-server/server/ocsp_peer.go	404	317	217	100	51.0
69.62	src/github.com/nats-io/nats-server/logger/log.go	401	260	181	79	12.0
70.47	...ub.com/nats-io/nats-server/server/jetstream_api.go	4652	3197	2253 + 2	944 - 2	3597.0 - 75
71.88	...rc/github.com/nats-io/nats-server/logger/syslog.go	132	64	46	18	29.0
72.91	...ithub.com/nats-io/nats-server/server/avl/seqset.go	677	443	323	120	1075558.0 - 5582
74.1	src/github.com/nats-io/nats-server/server/store.go	778	332	246	86	3376971.0 - 164018

85.18
src/

nats-io / nats-server / 10519998900
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10519998900

nats-io / nats-server / 10519998900 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10519998900

nats-io / nats-server / 10519998900
86%

README BADGES
x