JuliaLang / julia / #37872

86%

Build Type

push

local

Committed by web-flow

Commit Message

Fix push! for OffsetVectors, add tests for push! and append! on AbstractVector (#55480)

Per
https://github.com/JuliaLang/julia/pull/55470#discussion_r1714000529,
the `push!(::AbstractArray, ...)` array implementation assumed one-based
indexing and did not account for an `OffsetVector`
scenario.

Here we add tests for `push!(::AbstractArray, ...)` and
`append(::AbstractArray, ...)` including using `@invoke` to test the
effect on `OffsetVector`.

cc: @fredrikekre

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

43 existing lines in 4 files now uncovered.

78090 of 88954 relevant lines covered (87.79%)

16467426.86 hits per line