JuliaLang / julia / #37866

86%

Build Type

push

local

Committed by web-flow

Commit Message

compiler: apply more accurate effects to return_type_tfunc (#55338)

In extreme cases, the compiler could mark this function for
concrete-eval, even though that is illegal unless the compiler has first
deleted this instruction. Otherwise the attempt to concrete-eval will
re-run the function repeatedly until it hits a StackOverflow.

Workaround to fix #55147

@aviatesk You might know how to solve this even better, using
post-optimization effect refinements? Since we should actually only
apply the refinement of terminates=false => terminates=true (and thus
allowing concrete eval) if the optimization occurs, and not just in
inference thinks the optimization would be legal.

---------

Co-authored-by: Shuhei Kadowaki <aviatesk@gmail.com>

Run Details

25 of 30 new or added lines in 8 files covered. (83.33%)

191 existing lines in 12 files now uncovered.

78056 of 88924 relevant lines covered (87.78%)

16403789.58 hits per line