rust-bitcoin / rust-bitcoin / 10126432600

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3098: Make `ScriptBuf::p2wpkh_script_code` stand alone

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/feef34fdea7714a4fd47e2771dd8bd50b30c6b85">feef34fde Make ScriptBuf::p2wpkh_script_code stand alone (Tobin C. Harding)

Pull request description:

  We would like to move the `Script` type to `primitives` without moving any key stuff, including pubkey hashes. We may later, before releasing `primitives`, move the `WPubkeyHash` at which time this patch can be reverted or re-implemented on `ScriptBuf`.

  The `ScriptBuf::p2wpkh_script_code` function does not take `self` as a parameter but it does return `Self` - this can trivially be made into a standalone function.

  Make `ScriptBuf::p2wpkh_script_code` a standalone function.

ACKs for top commit:
  Kixunil:
    ACK feef34fdea7714a4fd47e2771dd8bd50b30c6b85
  apoelstra:
    ACK feef34fdea7714a4fd47e2771dd8bd50b30c6b85

Tree-SHA512: 9de43bb277307ca39929351d2b171887329

10 of 11 new or added lines in 3 files covered. (90.91%)

19670 of 23638 relevant lines covered (83.21%)

15578.79 hits per line