rust-bitcoin / rust-bitcoin / 10125152671

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3010: Add `length` field to `sha256::Midstate`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/98fe6179db3a2e770d5c52647153e60ed2d3c313">98fe6179d<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d9981b3ac047493066c991f73c7694dadcc43804"> Use "unfinalized" in header of Midstate (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/86de586898448ab3d6d87fd2e6983466a654da0c">86de58689</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d9981b3ac047493066c991f73c7694dadcc43804"> Use const to construct Midstate (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/dcb18bfa7a25d4de0eb8c3bba73d3c2b1f4dae14">dcb18bfa7</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d9981b3ac047493066c991f73c7694dadcc43804"> Add length to sha256::Midstate (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/db0502d3cd6363b293518c4e1f768ba79c303c41">db0502d3c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d9981b3ac047493066c991f73c7694dadcc43804"> Use third person in rustdoc (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/34dd95f9098c41497243c60527606e8764e71716">34dd95f90</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d9981b3ac047493066c991f73c7694dadcc43804"> Debug Midstate forwards (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1d0e70b1da7037bb997c376f009217c4cd859c29">1d0e70b1d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d9981b3ac047493066c991f73c7694dadcc43804"> Add regression test for Midstate debug output (Tobin C. Harding)
ca823945f Manually implement AsRef (remove Borrow) (Tobin C. Harding)
7dc68b62e Remove serde from sha256::Midstate (Tobin C. Harding)
07e8e5d3a Stop using macro for Midstate (Tobin C. Harding)
37b54dd54 Move from_midstate function (Tobin C. Harding)
9efe4cea9 Move impl block under struct (Tobin C. Harding)
594100873 Import sha256t in docs builds (Tobin C. Harding)

Pull request description:

  "overhaul the midstate API" might be a better description. PR is broken up into many patches to the extreme to make sure all API the changes are easily noticed.

  Resolve: #2918

ACKs for top commit:
  Kixunil:
    ACK 98fe6179db3a2e770d5c52647153e60ed2d3c313
  apoelstra:
    ACK 98fe6179db3a2e770d5c52647153e60ed2d3c313

Tree-SHA512: 1384cdeea4b15c7749fd2f389835c7f9a6e

Coverage Stats

51 of 65 new or added lines in 2 files covered. (78.46%)

1 existing line in 1 file now uncovered.

19670 of 23638 relevant lines covered (83.21%)

15642.19 hits per line