Ouranosinc / xclim / 10114731662

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix wet spells - generic spell statistics (#1838)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1834
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Implements a generic spell length statistics function
* Use that function in dry and wet spells, which fixes wet spells
* That required me to implement the `reducer='count'` case in 1d
`rle_statistics`.

### Does this PR introduce a breaking change?
Yes, results for all wet spells indicators will change. But they were
not correct before.

Results for `dry_spell_frequency` are also different, were also not
correct previsouly.

### Other information:

Run Details

31 of 32 new or added lines in 3 files covered. (96.88%)

3 existing lines in 1 file now uncovered.

9033 of 9990 relevant lines covered (90.42%)

5.76 hits per line