10105827586

Committed 25 Jul 2024 03:26PM UTC coverage: 85.22% (+0.1%) from 85.106%

Build # 10105827586

Build Type

push

github

Committed by

web-flow

Commit Message

Fix `WorkQueuePolicy` retention issue (#5697)

The `isInterestRetention` function, which gates whether or not we run
`checkInterestState`, was matching for both `InterestPolicy` and
`WorkQueuePolicy`.

This meant that a work queue stream could throw away messages for which
there was no consumer interest as the consumer ack floors for other
subjects moved up.

This PR changes `isInterestRetention` to match only `InterestPolicy`
which fixes the issue. Notably this doesn't change the `ackMsg`
behaviour which will continue to remove messages once they have been
acked.

Signed-off-by: Neil Twigg <neil@nats.io>

Run Details

66124 of 77592 relevant lines covered (85.22%)

1220919.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.24

/src/github.com/nats-io/nats-server/server/route.go

Source Not Available

The file "src/github.com/nats-io/nats-server/server/route.go" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

nats-io / nats-server / 10105827586

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous