10105827586
85%

Ran 26 Jul 2024 05:36AM UTC

Jobs 1

Files 56

Run time 1min

Badge

Embed ▾

Committed 25 Jul 2024 03:26PM UTC coverage: 85.22% (+0.1%) from 85.106%

Build # 10105827586

Build Type

push

github

Committed by

web-flow

Commit Message

Fix `WorkQueuePolicy` retention issue (#5697)

The `isInterestRetention` function, which gates whether or not we run
`checkInterestState`, was matching for both `InterestPolicy` and
`WorkQueuePolicy`.

This meant that a work queue stream could throw away messages for which
there was no consumer interest as the consumer ack floors for other
subjects moved up.

This PR changes `isInterestRetention` to match only `InterestPolicy`
which fixes the issue. Notably this doesn't change the `ackMsg`
behaviour which will continue to remove messages once they have been
acked.

Signed-off-by: Neil Twigg <neil@nats.io>

Run Details

66124 of 77592 relevant lines covered (85.22%)

1220919.26 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	81.73	-0.09%	src/github.com/nats-io/nats-server/server/jetstream.go
2	83.82	0.1%	src/github.com/nats-io/nats-server/server/filestore.go
2	81.29	0.0%	src/github.com/nats-io/nats-server/server/opts.go
3	90.41	0.0%	src/github.com/nats-io/nats-server/server/leafnode.go
3	96.85	-0.26%	src/github.com/nats-io/nats-server/server/sublist.go
4	93.24	-0.17%	src/github.com/nats-io/nats-server/server/route.go
6	86.16	-0.12%	src/github.com/nats-io/nats-server/server/accounts.go
9	94.44	-0.16%	src/github.com/nats-io/nats-server/server/client.go
10	70.4	-0.19%	src/github.com/nats-io/nats-server/server/jetstream_api.go
13	80.16	0.86%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
27	83.09	0.1%	src/github.com/nats-io/nats-server/server/raft.go
82	84.72	0.22%	src/github.com/nats-io/nats-server/server/stream.go
186	87.26	0.08%	src/github.com/nats-io/nats-server/server/consumer.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	10105827586.1	26 Jul 2024 05:36AM UTC	56	85.22	GitHub Action Run

nats-io / nats-server / 10105827586
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10105827586

nats-io / nats-server / 10105827586 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10105827586

nats-io / nats-server / 10105827586
85%

README BADGES
x