PrincetonUniversity / PsyNeuLink / 10096900829

85%

master: 85%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor/autodiff and emcomposition (#3011)

• processingmechanism.py:
  - _instantiate_output_ports():
     if no OutputPorts are specified, and variable has more than one item, assign one OutputPort to each
• Tests for multiple output_ports with learning need to be added
• test_learning.py
  - TestAutodiffMultipleOutput_port:
    - add test_parallel_inputs_to_output_ports_converge_internal
    - add test_single_input_to_multiple_output_ports_converge_internal
    - add test_single_input_to_multiple_output_ports_converge_on_OUTPUT_Node
• composition.py
  - _create_backpropagation_learning_pathway():
    - raise error for terminal node with > 1 output_ports
   _instantiate_input_dict():  refactor to format user-specified inputs
   _instantiate_input_dict():
  - NodeRoles: add BIAS
  - _determine_node_roles: assign NodeRole.BIAS
• test_composition.py:   add test_input_shape_errors
• processingmechanism.py:  docstring description of configuration
• test_processing_mechanism.py
  - test_processing_mechanism_multiple_input_ports: add tests for specifying names and/or variables for output_ports
• autodiffcomposition.py
  infer_backpropagation_learning_pathways():
  - only exclude ModulatoryProjections or ones that don't have a 'learnable' attribute
• emcomposition.py
  - execute(): 
    - autodiff execution commented out
    - execute(): use autodiff
    - replace key_input_node(s) with query_input_node(s)
• pytorchcomponents.py
   - pytorch_function_creator:  
      - implement support for EMStorage
      - fix bug in softmax
      - remove pytorch_function_creator
• learningfunctions.py: EMStorage: minor fixes
• pytorchEMcompositionwrapper.py:
  - subclass PytorchCompositionWrapper to handle functionality of EMStorage
  - store_memory(): implementing
• EMstoragemechanism.py
   - store_memory(): implement get_memory
• test_composition.py
  add test_BIAS
• pytorchcomponents.py
• function.py
  - Function: add _get_... (continued)

Run Details

11680 of 15048 branches covered (77.62%)

Branch coverage included in aggregate %.

404 of 560 new or added lines in 17 files covered. (72.14%)

45 existing lines in 4 files now uncovered.

31992 of 37097 relevant lines covered (86.24%)

0.86 hits per line