Ran
|
Jobs
1
|
Files
479
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
vinyl: skip bad vylog records in force_recovery mode We've had a number of issues when Tarantool was permanently broken (unable to recover after restart) because of a bad vylog record. The `force_recovery` mode didn't help so the user would have no other choice but to rebootstrap. A funny thing is those bugs were usually caused by a race between the garbage collector and dump/compaction when a vylog record was written for a dropped index. The worst thing that could happen if we ignored such a bad record is an unused run file not deleted from disk. Apparently, this is better than a permanent recovery failure so let's support the `force_recovery` mode in vylog. The tricky part here is handling checkpoint after restart. The problem is that to create a vylog checkpoint, we load the previous vylog file so we have to ignore errors if it was loaded in the `force_recovery` mode. Closes #10292 NO_DOC=bug fix (cherry picked from commit c68e8a8e0)
62760 of 113890 branches covered (55.11%)
31 of 33 new or added lines in 1 file covered. (93.94%)
217 existing lines in 12 files now uncovered.93641 of 109053 relevant lines covered (85.87%)
2459828.55 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
2 |
88.12 |
4.09% | src/box/vy_log.c |
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
90.03 |
-0.08% | src/box/applier.cc |
1 |
93.33 |
-0.11% | src/lib/core/fiber.c |
1 |
94.26 |
-0.16% | src/box/replication.cc |
1 |
91.45 |
-0.11% | src/lib/swim/swim.c |
2 |
87.05 |
-0.14% | src/box/vy_run.c |
2 |
92.81 |
-1.44% | src/box/vy_point_lookup.c |
2 |
92.25 |
-0.05% | src/box/vinyl.c |
2 |
94.81 |
-0.55% | src/box/tuple.c |
5 |
91.89 |
0.13% | src/box/lua/error.cc |
15 |
91.49 |
-2.5% | src/box/memtx_space.c |
51 |
90.48 |
0.66% | src/box/key_def.c |
134 |
88.12 |
4.09% | src/box/vy_log.c |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 10074324916.1 | 479 |
85.87 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
---|