tarantool / tarantool / 10054626473

86%

master: 88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: do not log dump if index was dropped

An index can be dropped while a memory dump is in progress. If the vinyl
garbage collector happens to delete the index from the vylog by the time
the memory dump completes, the dump will log an entry for a deleted
index, resulting in an error next time we try to recover the vylog,
like:

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Run 2 committed after deletion
```

or

```
ER_INVALID_VYLOG_FILE: Invalid VYLOG file: Deleted range 9 has run slices
```

We already fixed a similar issue with compaction in commit 29e2931c66c5
("vinyl: fix race between compaction and gc of dropped LSM"). Let's fix
this one in exactly the same way: discard the new run without logging it
to the vylog on a memory dump completion if the index was dropped while
the dump was in progress.

Closes #10277

NO_DOC=bug fix

(cherry picked from commit ae6a02eba)

Run Details

62743 of 114024 branches covered (55.03%)

3 of 3 new or added lines in 1 file covered. (100.0%)

9 existing lines in 3 files now uncovered.

93650 of 109113 relevant lines covered (85.83%)

2615236.45 hits per line