Unleash / unleash / 9972817648

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Update OpenAPI error converter to handle query param errors too (#7609)

This PR updates the OpenAPI error converter to also work for errors with
query parameters.
We previously only sent the body of the request along with the error,
which meant that query parameter errors would show up incorrectly.

For instance given a query param with the date format and the invalid
value `01-2020-01`, you'd previously get the message:
> The `from` value must match format "date". You sent undefined

With this change, you'll get this instead:
> The `from` value must match format "date". You sent "01-2020-01". 

The important changes here are two things:
- passing both request body and query params
- the 3 lines in `fromOpenApiValidationError` that check where we should
get the value you sent from.

The rest of it is primarily updating tests to send the right arguments
and some slight rewording to more accurately reflect that this can be
either request body or query params.

Coverage Stats

2563 of 3372 branches covered (76.01%)

4 of 4 new or added lines in 1 file covered. (100.0%)

6 existing lines in 1 file now uncovered.

13146 of 14998 relevant lines covered (87.65%)

704.22 hits per line