rust-bitcoin / rust-bitcoin / 9879535201

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2987: Add `TxIdentifier` trait

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a738754f6721335330b0335d53bc4706c33d2861">a738754f6 Add TxIdentifier trait (Tobin C. Harding)

Pull request description:

  Add a new trait `TxIdentifier` that abstracts over the `Txid` and `Wtxid` types. We make `AsRef` a super trait so that the new trait needs no methods.

  Seal the trait so consumers of the library cannot implement it.

  Use the new trait in:

  - the `bip152` module to tighten up the `with_siphash_keys` function
  - as a trait bound on the `Leaf` associated type in the `MerkleNode` trait

ACKs for top commit:
  apoelstra:
    ACK a738754f6721335330b0335d53bc4706c33d2861
  Kixunil:
    ACK a738754f6721335330b0335d53bc4706c33d2861

Tree-SHA512: a7bda26a4bdec3434b89038c80d1ab55cd6

3 of 5 new or added lines in 1 file covered. (60.0%)

19552 of 23539 relevant lines covered (83.06%)

15688.65 hits per line