rust-bitcoin / rust-bitcoin / 9878993932

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2988: Add additional `HashEngine` types

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/51010777bf4b4e738348855d5e637ea8f5571570">51010777b<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/66b0b528706408b763d8b4127c4ad6d3c7ff17d1"> hashes: Strongly type the hash160::HashEngine (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d5dd54a489a43effcd38df46e1eb7825f6cae464">d5dd54a48</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/66b0b528706408b763d8b4127c4ad6d3c7ff17d1"> hashes: Strongly type the sha256d::HashEngine (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a7422a779c1fb47fef5b092c9e8458dd3108f4db">a7422a779</a> hashes: Add const hash engine constructors (Tobin C. Harding)

Pull request description:

  Currently we are using a type alias for a few of the hash engines.

  Type alias' allow for potential mixing of types, a struct can better serve our users with not much additional complexity or maintenance burden.

  - As preparation add const constructors where possible to hash engines (excl. `HmacEngine`).
  - Add a `sha256d::HashEngine` struct
  - Add a `hash160::HashEngine` struct

  If this goes in we can improve the `sha256t::HashEngine` in a similar manner.

ACKs for top commit:
  Kixunil:
    ACK 51010777bf4b4e738348855d5e637ea8f5571570
  apoelstra:
    ACK 51010777bf4b4e738348855d5e637ea8f5571570 but will hold off on merging until tcharding indicates whether he wants to address the midstate thing

Tree-SHA512: 810db3a8cc531619bbfb32bffbf63489f63

42 of 48 new or added lines in 11 files covered. (87.5%)

19554 of 23541 relevant lines covered (83.06%)

15657.24 hits per line