JuliaLang / julia / #37831

87%

Build Type

push

local

Committed by web-flow

Commit Message

lowering: Don't resolve type bindings earlier than necessary (#54999)

This is a follow up to resolve a TODO left in #54773 as part of
preparatory work for #54654. Currently, our lowering for type definition
contains an early `isdefined` that forces a decision on binding
resolution before the assignment of the actual binding. In the current
implementation, this doesn't matter much, but with #54654, this would
incur a binding invalidation we would like to avoid.

To get around this, we extend the (internal) `isdefined` form to take an
extra argument specifying whether or not to permit looking at imported
bindings. If not, resolving the binding is not required semantically,
but for the purposes of type definition (where assigning to an imported
binding would error anyway), this is all we need.

Run Details

4 of 6 new or added lines in 1 file covered. (66.67%)

4 existing lines in 3 files now uncovered.

77281 of 88321 relevant lines covered (87.5%)

16103219.22 hits per line