AAEmu / AAEmu / 9819786774

2%

Build Type

push

github

Committed by web-flow

Commit Message

[Game] Moved NPC events out of dungeons and onto all NPCs (#994)

- Added null-check to ``SkillManager.GetNpSkillTemplate``
- Fixed missing ``s`` typo in ``GetNpSkill``
- Changed ``DoodadFuncRequireQuests`` to be ignored if caster is not a ``Character``. This is mostly used in Doodad's initial state, and would work better if it's a actual spawn check rather than a conditional check on it's own. This is likely supposed to check the caster's killer if it's called from a OnDeath event. But works good enough to get the quests done for now.
- Moved the NPC event functions from ``Dungeon`` into a new partial class Npc file ``NpcEvents.cs`` and linked it to the standard spawners.
- Lowered the logging level of dungeon notifications

Run Details

439 of 23802 branches covered (1.84%)

Branch coverage included in aggregate %.

0 of 221 new or added lines in 8 files covered. (0.0%)

2 existing lines in 2 files now uncovered.

1828 of 81457 relevant lines covered (2.24%)

2.44 hits per line