safe-global / safe-smart-account / 9710052157

94%

push

github

Create a pre call hook onBeforeExecTransaction (#776)

Fixes #775, #735

To have a broader context on overall changes in the code use this
[diff](https://github.com/safe-global/safe-smart-account/compare/499b17ad..improvement-execTransaction-post-call-hook)

### Changes in PR:
- Add a pre-hook function onBeforeExecTransaction
- Refactor changes in #772, #774
- Add a pre-hook function onBeforeExecTransactionFromModule
- Change function visibility of execTransaction from public to external

### Code size change

Increase by 51 bytes in Safe with diff:
https://github.com/safe-global/safe-smart-account/compare/499b17ad..improvement-execTransaction-post-call-hook:

#### This PR
```
Safe 21832 bytes (limit is 24576)
SafeL2 22612 bytes (limit is 24576)
```

####
[Commit](https://github.com/safe-global/safe-smart-account/commit/499b17ad0)
(Prior to merging #772)

```
Safe 21781 bytes (limit is 24576)
SafeL2 22623 bytes (limit is 24576)
```

### Gas usage with Safe contract

- Increase by 79 gas in execTransaction calls
- Increase by 44 gas in execTransactionFromModule* calls

#### This PR

```
·------------------------------------------------------------|----------------------------|-------------|------------------------------·
|                    Solc version: 0.7.6                     ·  Optimizer enabled: false  ·  Runs: 200  ·  Block limit: 100000000 gas  │
·····························································|····························|·············|·······························
|  Methods                                                                                                                             │
·····················|·······································|·············|··············|·············|···············|···············
|  Contract          ·  Method                               ·  Min        ·  Max         ·  Avg        ·  # calls      · ... (continued)

253 of 290 branches covered (87.24%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

388 of 400 relevant lines covered (97.0%)

98.52 hits per line