safe-global / safe-smart-account / 9676758763

94%

push

github

Fix compilation issue with solidity versions >= 0.8.12 (#772)

Fixes: #735 and #773

### Changes in PR
- Add a hook function `_onAfterExecTransactionFromModule` that gets
called after execution from module.
- SafeL2 overrides this function to emit event `SafeModuleTransaction`.
- Add test that checks if `execTransactionFromModuleReturnData` in
SafeL2 emits `SafeModuleTransaction` event.

#### Codesize increase by `33` bytes with compiler version 0.7.6 

#### This PR:

```
Safe 21814 bytes (limit is 24576)
SafeL2 22632 bytes (limit is 24576)
```

#### Main branch
```
Safe 21781 bytes (limit is 24576)
SafeL2 22623 bytes (limit is 24576)
```


### Impact on gas usage with `Safe` contract

Changes in this PR add additional overhead of `49` gas

####  This PR:

```
·------------------------------------------------------------|----------------------------|-------------|------------------------------·
|                    Solc version: 0.7.6                     ·  Optimizer enabled: false  ·  Runs: 200  ·  Block limit: 100000000 gas  │
·····························································|····························|·············|·······························
|  Methods                                                                                                                             │
·····················|·······································|·············|··············|·············|···············|···············
|  Contract          ·  Method                               ·  Min        ·  Max         ·  Avg        ·  # calls      ·  usd (avg)   │
·····················|·······································|·············|··············|·············|···············|···············
|  Safe              ·  execTransactionFromModule            ·      51630  ·      184223  ·     127865  ·           11  ·           -  │
·····················|·······································|·············|··... (continued)

253 of 290 branches covered (87.24%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

389 of 401 relevant lines covered (97.01%)

97.69 hits per line