9671553913
94%
main: 96%

Ran 26 Jun 2024 12:39AM UTC

Jobs 1

Files 768

Run time 1min

Badge

Embed ▾

Committed 26 Jun 2024 12:32AM UTC coverage: 94.396%. First build

Build # 9671553913

Build Type

Pull #2197

github

Committed by

nimmolo

Commit Message

Fix "Turn off admin mode" link in nav menu

Fixes #2168. Adds test. @JoeCohen - In case you tried to fix this and got stumped, it wasn't working because this link needs to submit a "POST" request.

Here's how to build links like this:
- the link must use `button_to`, rather than a `link_to`
- the button needs a couple extra classes to style it like an `<a>` if that's what we want

Rails supposedly allows `link_to` with `data: { turbo_method: :post }` but in reality (at least on MO) it doesn't work, the CSRF stops the link from working.

Also, the [Turbo docs themselves state](https://turbo.hotwired.dev/handbook/drive#performing-visits-with-a-different-method) "you should also consider that for accessibility reasons, it’s better to use actual forms and buttons for anything that’s not a GET." The Rails `button_to` helper builds a form and a button, as you probably know.

Pull Request Pull Request #2197: Fix "Turn off admin mode" link in nav menu

Run Details

26158 of 27711 relevant lines covered (94.4%)

556.92 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	9671553913.1	26 Jun 2024 12:39AM UTC	0	94.4	GitHub Action Run

Source Files on build 9671553913

Detailed source file information is not available for this build.

MushroomObserver / mushroom-observer / 9671553913
94%
main: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9671553913

MushroomObserver / mushroom-observer / 9671553913 94% main: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9671553913

MushroomObserver / mushroom-observer / 9671553913
94%
main: 96%

README BADGES
x