rust-bitcoin / rust-bitcoin / 9663915609

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2910: hashes: split `Hash` into `GeneralHash` and `Hash`

8bd5c6443 api changes for "drop GeneralHash from wrapped hash types" (Andrew Poelstra)
91265977f hashes: stop exposing engine/from_engine and general hashing methods in hash_newtype (Andrew Poelstra)
8c4899f2c bitcoin: remove all direct use of hashing/engines in unit tests (Andrew Poelstra)
b8d85a1df bitcoin: remove all use of engine/from_engine on opaque hash types (Andrew Poelstra)
0aa539f83 hashes: remove engine/from_engine from embedded test (Andrew Poelstra)
46dad847f api changes for split between Hash/GeneralHash (Andrew Poelstra)
73dcc7976 hashes: split Hash trait into two (Andrew Poelstra)
1fe4c6398 hashes: remove unused Hash import in embedded test (Andrew Poelstra)

Pull request description:

  I'm not thrilled with these names. Personally I would prefer having `ByteArrayWrapper` (for non-general hashes) and `Hash` (for general hashes). But using `Hash` and `GeneralHash` greatly minimizes the diff because most of our use of the `Hash` trait was only for non-general stuff.

  Maybe that tradeoff will change as we move stuff to inherents? I hope to do that in the next PR (or maybe the one after that, since I still have some "drop `GeneralHash` work to do for tagged hashes). And after that the hashing API should be "clean" enough that we can figure out HashEngine, possibly even folding GeneralHash into it. But that's the part of #2770 that we didn't finish nailing down so I'm not sure.

  But other than naming, I like this PR. I think, if you approve of this PR except the naming, it would be best to ACK it and then we can do a followup rename-only PR, rather than dealing with the review pain of mass-renaming in r... (continued)

Run Details

88 of 107 new or added lines in 17 files covered. (82.24%)

1 existing line in 1 file now uncovered.

19564 of 23528 relevant lines covered (83.15%)

15660.47 hits per line