rust-bitcoin / rust-bitcoin / 9639464882

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2877: hashes: remove `all_zeros` and constify constructors

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/4652ce20ed8e397d297d0a2e91b61730dcbdf498">4652ce20e<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b904de375a69db57fa59b3e8a0ba19a7cc7cdb55"> API changes for "delete `all_zeros`" (Andrew Poelstra)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8869f35a69b606527c04aba10f0105e9c23ed8b8">8869f35a6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b904de375a69db57fa59b3e8a0ba19a7cc7cdb55"> hashes: drop the `all_zeros` method on arbitrary hashes (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9f8797f4863a4e82d42aa170c750daaf57ad4ed9">9f8797f48</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b904de375a69db57fa59b3e8a0ba19a7cc7cdb55"> API changes for constification of hash constructors (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/154e91af8c5ad81753bef3eea331d4b702600cb7">154e91af8 hashes: constify a bunch of constructors (Andrew Poelstra)
c155cbf8b hashes: use workaround to get constfns on tagged hashes with MSRV (Andrew Poelstra)

Pull request description:

  I think these changes are both uncontroversial but they have fairly large diffs so I am PRing them together before making more invasive changes.

ACKs for top commit:
  tcharding:
    ACK 4652ce20ed8e397d297d0a2e91b61730dcbdf498

Tree-SHA512: 4560fa3979901a84dbebcee5e222fdf52a2

28 of 30 new or added lines in 9 files covered. (93.33%)

19542 of 23504 relevant lines covered (83.14%)

15639.94 hits per line