ooni / probe-cli / 9413861967

72%

Build Type

push

github

Committed by web-flow

Commit Message

cleanup(pkg/oonimkall): simplify test code (#1619)

This diff simplifies test code in `pkg/oonimkall` in preparation for
further richer-input related changes.

Part of https://github.com/ooni/probe/issues/2607.

While there (a) realize we don't need anymore to init the example
experiment name in its factory constructor, so normalize its
construction to be equal to all the other experiments; (b) realize that
the `TestTaskRunnerRun` does not require the network and is ~short, so
there's no point to skip it when in short mode; (c) avoid using the
deprecated `legacy/mockable` package and instead use the `mocks`
package.

Run Details

31 of 36 new or added lines in 4 files covered. (86.11%)

1 existing line in 1 file now uncovered.

27867 of 33108 relevant lines covered (84.17%)

52.7 hits per line