ooni / probe-cli / 9413198176

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(dnscheck): implement richer input (#1618)

This diff:

1. modifies `./internal/registry` and its `dnscheck.go` file such that
`dnscheck` has its own private target loader;
2. modifies `./internal/targetloading` to allow reusing the code to read
static input from CLI and from files;
3. modifies `./internal/model` to pass optional richer input to
experiments;
4. modifies `./internal/engine` to pass richer input to experiments;
5. modifies `./internal/experiment/dnscheck` to read and use the richer
input it is passed;
6. implements a custom target loader for
`./internal/experiment/dnscheck` returning some static entries;
7. modifies `./internal/oonirun` to make sure richer-input experiments
honor their options by moving option loading before the loading of
targets.

Once this diff is merged, `miniooni` and `ooniprobe` will run `dnscheck`
with richer input. Obviously, we are still lacking an API to fetch
richer input, so for now this is static richer input, suitable as a
starting point to land more diffs.

Part of https://github.com/ooni/probe/issues/2607.

Run Details

151 of 166 new or added lines in 10 files covered. (90.96%)

5 existing lines in 2 files now uncovered.

27592 of 33104 relevant lines covered (83.35%)

51.77 hits per line