rust-bitcoin / rust-bitcoin / 9324941754

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2644: Add HKDF to bitcoin_hashes

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c9d1ff7037aa47d5a0690d994cb1587908f201b8">c9d1ff703<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d1cab68eee59f79c3ec76cf393438471b68fe69"> Update hashes API changes (Nick Johnson)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/878ab924d1ff020cecb4f057a5143ac30558f25f">878ab924d</a> Add HMAC Extract-and-Expand Key Derivation Function (Nick Johnson)

Pull request description:

  rustaceanrob and I have been working on a Rust-based BIP324 implementation over at https://github.com/rustaceanrob/bip324. We have been attempting to keep the code pretty clean in hopes of a future "soft landing" in rust-bitcoin. I figured the HKDF implementation is a small, self-contained chunk that might allow us to learn the ropes here first.

  There was a mention in the [discussion thread on BIP324](https://github.com/rust-bitcoin/rust-bitcoin/discussions/1691) that the hashes interface may be changing in the near future. I am not sure the effect that would have on this implementation, but happy to work through any issues.

  Closes #2551

ACKs for top commit:
  tcharding:
    ACK c9d1ff7037aa47d5a0690d994cb1587908f201b8
  apoelstra:
    ACK c9d1ff7037aa47d5a0690d994cb1587908f201b8

Tree-SHA512: 404d51ca0f36a20a1713953a3e737c65127

111 of 114 new or added lines in 1 file covered. (97.37%)

19450 of 23357 relevant lines covered (83.27%)

16646.46 hits per line