rust-bitcoin / rust-bitcoin / 9322788249

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2818: CI: Remove shebang from non-executable scripts

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/60ab3d26e5d5d8d82148b8727365e238f41e810b">60ab3d26e CI: Remove shebang from non-executable scripts (Tobin C. Harding)

Pull request description:

  Some of our CI shell scripts are meant only to be sourced and not run directly however they include an initial shebang line, implying that they should be run.

  Remove the shebang line from `crates.sh` and the various `test_vars.sh` scripts. Add a `shellcheck` directive to inhibit the no-shebang warning.

  Please note, the issue mentions the following in the discussion thread and it is _not_ implemented here.

  > It would be good also to find a way to detect whether the script is being run directly, and to print an error message. I'm sure this is a common thing and we can find a stackexchange post telling us how to do it.

  I don't see an immediate way to do this because CI is run using `run_task.sh` which is not in this repo. And since one can still run a script without the shebang (by doing eg, `bash script.sh`) the lack of shebang is only an indicator of how we are using the script.

  Fix: #2764

ACKs for top commit:
  apoelstra:
    ACK 60ab3d26e5d5d8d82148b8727365e238f41e810b

Tree-SHA512: fe829226f3637e9b7ffd03f4563bf6e0205

19339 of 23243 relevant lines covered (83.2%)

16681.41 hits per line