djeedai / bevy_hanabi / 9140425792

66%

Build Type

push

github

Committed by web-flow

Commit Message

Fix storage padding and re-enable buffer clean-up (#324)

Fix the padding of all storage buffers to comply with the GPU device requirements, which on most Desktop platforms is 32 bytes, but can be different (for example on macOS M1 and later, it's generally 256 bytes). This fixes a number of issues where effects are not rendering at all, or display strong artifacts. The change is likely over-doing it by padding all structures used in arrays, however this can be optimized as a later pass.

Fix a bug in the `CloneModifier` where the shader code was allocating cloned particles without checking the buffer capacity, leading to underflow error and stomping over other parts of the buffer.

Re-enable buffer cleaning up on effect deletion, which was commented out during the ribbon change but not fixed, and left disabled. This caused the buffers to fill, leaving no space for new effects even after some effects were deleting, which resulted in newly spawned effects not updating (code was dispatching 0 workground in update pass).

Fixes #322

Run Details

59 of 187 new or added lines in 4 files covered. (31.55%)

82 existing lines in 8 files now uncovered.

3022 of 5732 relevant lines covered (52.72%)

22.8 hits per line